This repository has been archived by the owner on Jan 24, 2024. It is now read-only.
Resolve border colors in variations #722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this will do. The other border top in pricing are fine as-is, as they are entirely decorative. |
richtabor
changed the title
|
Should we remove base-3 from the palette if we are not using it, then? |
MaggieCabrera
force-pushed
the
fix/border-colors
branch
from
daf7d1a to
8c8afc3
Compare
|
I put the separators back to pricing but using contrast 3. I think it looks better with them even if they are a little darker than the original design. I also replaced base 3 with contrast 3 in the single template (it had the same contrast issue on the affected theme variations) and removed the base 3 color from all variations, since the color is no longer used on templates or patterns. This way we are not confusing the users by providing a color that doesn't really contrast how it's supposed to. |
markjaquith
pushed a commit
to markjaquith/WordPress
that referenced
this pull request
Nov 6, 2023
This update includes the following changes: * [WordPress/twentytwentyfour#723 Remove custom CSS for links]. * [WordPress/twentytwentyfour#718 Fix the link to the theme's docs]. * [WordPress/twentytwentyfour#719 Separate outline css to its own function] - which introduces `twentytwentyfour_block_stylesheets()` for enqueuing custom block stylesheets. * [WordPress/twentytwentyfour#720 Fix height of newsletter landing pattern]. * [WordPress/twentytwentyfour#722 Resolve border colors in variations]. Follow up to [57036], [56999], [56951], [56813], [56764], [56716]. Props onemaggie, richtabor, luminuu, huzaifaalmesbah, sabernhardt, poena, rajinsharwar. Fixes #59812. Built from https://develop.svn.wordpress.org/trunk@57067 git-svn-id: http://core.svn.wordpress.org/trunk@56578 1a063a9b-81f0-0310-95a4-ce76da25c4cd
github-actions bot
pushed a commit
to gilzow/wordpress-performance
that referenced
this pull request
Nov 6, 2023
This update includes the following changes: * [WordPress/twentytwentyfour#723 Remove custom CSS for links]. * [WordPress/twentytwentyfour#718 Fix the link to the theme's docs]. * [WordPress/twentytwentyfour#719 Separate outline css to its own function] - which introduces `twentytwentyfour_block_stylesheets()` for enqueuing custom block stylesheets. * [WordPress/twentytwentyfour#720 Fix height of newsletter landing pattern]. * [WordPress/twentytwentyfour#722 Resolve border colors in variations]. Follow up to [57036], [56999], [56951], [56813], [56764], [56716]. Props onemaggie, richtabor, luminuu, huzaifaalmesbah, sabernhardt, poena, rajinsharwar. Fixes #59812. Built from https://develop.svn.wordpress.org/trunk@57067 git-svn-id: https://core.svn.wordpress.org/trunk@56578 1a063a9b-81f0-0310-95a4-ce76da25c4cd
pento
pushed a commit
to WordPress/wordpress-develop
that referenced
this pull request
Nov 6, 2023
This update includes the following changes: * [WordPress/twentytwentyfour#723 Remove custom CSS for links]. * [WordPress/twentytwentyfour#718 Fix the link to the theme's docs]. * [WordPress/twentytwentyfour#719 Separate outline css to its own function] - which introduces `twentytwentyfour_block_stylesheets()` for enqueuing custom block stylesheets. * [WordPress/twentytwentyfour#720 Fix height of newsletter landing pattern]. * [WordPress/twentytwentyfour#722 Resolve border colors in variations]. Follow up to [57036], [56999], [56951], [56813], [56764], [56716]. Reviewed by desrosj. Merges [57067] to the 6.4 branch. Props onemaggie, richtabor, luminuu, huzaifaalmesbah, sabernhardt, poena, rajinsharwar. Fixes #59812. git-svn-id: https://develop.svn.wordpress.org/branches/6.4@57070 602fd350-edb4-49c9-b593-d223f7449a82
markjaquith
pushed a commit
to markjaquith/WordPress
that referenced
this pull request
Nov 6, 2023
This update includes the following changes: * [WordPress/twentytwentyfour#723 Remove custom CSS for links]. * [WordPress/twentytwentyfour#718 Fix the link to the theme's docs]. * [WordPress/twentytwentyfour#719 Separate outline css to its own function] - which introduces `twentytwentyfour_block_stylesheets()` for enqueuing custom block stylesheets. * [WordPress/twentytwentyfour#720 Fix height of newsletter landing pattern]. * [WordPress/twentytwentyfour#722 Resolve border colors in variations]. Follow up to [57036], [56999], [56951], [56813], [56764], [56716]. Reviewed by desrosj. Merges [57067] to the 6.4 branch. Props onemaggie, richtabor, luminuu, huzaifaalmesbah, sabernhardt, poena, rajinsharwar. Fixes #59812. Built from https://develop.svn.wordpress.org/branches/6.4@57070 git-svn-id: http://core.svn.wordpress.org/branches/6.4@56581 1a063a9b-81f0-0310-95a4-ce76da25c4cd
julija1
reviewed
Dec 8, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #686 by using base and contrast only in patterns, so that colors are persistent across variations. This is another limitation that color sets and WordPress/gutenberg#53996 would reduce.
Also removes the border applied by the style; instead the pattern adds the borders to the details block. This way, you can style the details block however you'd like without having to figure out where the border came from. The arrow block style is direct in that it provides an arrow (in chrome).
Screenshots
Testing Instructions